The color attribute does not nclude an alpha component but the RGB types were including an alpha of 255 in their color attributes. The 0xFF was being assigned to the blue component hence the error.
* add support for cartridge size type $54
Added support for cartridge size type $54, corresponding to 1.5 MiB (96 banks).
* add missing license
* Add GBA Cartridge Header
* Update README.md
Added GBA information to README.md and corrected a typo.
* Add DS Cartridge Header
* Update ReadMe.md
* Update pyc.hexpat
Included additional versions
* Implement Windows thumbcache pattern
* Include thumbcache pattern in README.md
* Update thumbcache.hexpat
- Use English warning text
- handle unknown file version
- add thanks to joachimmetz
- create virtual file
- use more elegant magic type
* Update thumbcache.hexpat
- Use padding data type for paddings
* Update thumbcache.hexpat
- make pattern more robust against single erroneous cache record
* patterns/zip: simplify find_sequence_in_range check
hex(340282366920938463463374607431768211455) =
0xffffffffffffffffffffffffffffffff
* patterns/7z: use Magic<> for signature, add pragma
* patterns/{nro, ogg}: use Magic<> for signature
* patterns/ttf: refactor, check magic
Use the "Field field @ position;" syntax instead of saving and restoring
the cursor position.
* readme: fix copy-paste error in pattern listing
Fixes#348
In issue #348 it is stated that the pattern fails to find the variable baseAddress in the parent of the parent of the attribute function. One parent is required to access the variables on the pattern that is using the attribute.
That pattern is used in the pattern that contains baseAddress as a pointer to an array of the children pattern and that seems to require an extra parent level to be added in order to access baseAddress without errors. The fix was tested on an xbe file extracted from an xbox cd rom and while it failed without the fix as stated in issue 348 with the fix it ran to completion without issues.
In issue #346 it is noted that the format functions return the same value repeatidly and erroneously. This is due to the use of global variables which result on only their last value being used in format functions due to their delayed evaluation. Fixed by using local variables instead. Also remove tabs from the file and an unused tags variable.
* *Add top level CMakeLists.txt, to make it easier to use both independently and from within other projects
* Add a unit_test target, to attach all unit tests to
* * Fix unit tests for windows
* Silence cmake warning regarding missing top project
* update .gitignore for vscode
---------
Co-authored-by: BobSmun <6492115+BobSmun@users.noreply.github.com>
