build: Bumped version to 1.23.1

.github/workflows/release.yml

@@ -133,7 +133,7 @@ jobs:
       - name: ⬇️ Download dependencies
         shell: pwsh
         run: |
-          iwr https://github.com/microsoft/winget-create/releases/download/v1.0.4.0/wingetcreate.exe -OutFile wingetcreate.exe
+          iwr https://github.com/microsoft/winget-create/releases/download/v1.1.2.0/wingetcreate.exe -OutFile wingetcreate.exe
       - name: ⬆️ Update winget manifest
         shell: pwsh
         env:

VERSION

@@ -1 +1 @@
-1.23.0
+1.23.1

lib/libimhex/include/hex/providers/buffered_reader.hpp

@@ -24,6 +24,9 @@ namespace hex::prv {
         }
 
         void setEndAddress(u64 address) {
+            if (address >= this->m_provider->getActualSize())
+                address = this->m_provider->getActualSize() - 1;
+
             this->m_endAddress = address;
         }
 
@@ -256,7 +259,7 @@ namespace hex::prv {
     private:
         void updateBuffer(u64 address, size_t size) {
             if (!this->m_bufferValid || address < this->m_bufferAddress || address + size > (this->m_bufferAddress + this->m_buffer.size())) {
-                const auto remainingBytes = (this->m_endAddress - address) - 1;
+                const auto remainingBytes = (this->m_endAddress - address) + 1;
                 if (remainingBytes < this->m_maxBufferSize)
                     this->m_buffer.resize(remainingBytes);
                 else

lib/libimhex/source/api/imhex_api.cpp

@@ -247,7 +247,7 @@ namespace hex {
         }
 
         bool isValid() {
-            return !s_providers.empty() && s_currentProvider < i64(s_providers.size());
+            return !s_providers.empty() && s_currentProvider >= 0 && s_currentProvider < i64(s_providers.size());
         }
 
         void markDirty() {

plugins/builtin/source/content/data_formatters.cpp

@@ -18,7 +18,7 @@ namespace hex::plugin::builtin {
 
         auto reader = prv::BufferedReader(provider);
         reader.seek(offset);
-        reader.setEndAddress(offset + size);
+        reader.setEndAddress(offset + size - 1);
 
         u64 index = 0x00;
         for (u8 byte : reader) {
@@ -160,7 +160,7 @@ namespace hex::plugin::builtin {
 
             auto reader = prv::BufferedReader(provider);
             reader.seek(offset);
-            reader.setEndAddress(offset + size);
+            reader.setEndAddress((offset + size) - 1);
 
             u64 address = offset & ~u64(0x0F);
             std::string asciiRow;

plugins/builtin/source/content/views/view_hex_editor.cpp

@@ -1576,7 +1576,8 @@ namespace hex::plugin::builtin {
             }
 
             if (ImGui::MenuItem("hex.builtin.view.hex_editor.menu.edit.remove"_lang, nullptr, false, providerValid && provider->isResizable())) {
-                this->openPopup<PopupRemove>(this->getSelection().getStartAddress(), 0x00);
+                auto selection = this->getSelection();
+                this->openPopup<PopupRemove>(selection.getStartAddress(), selection.getSize());
             }
         });
     }