build: Bumped version to 1.18.1

This actually fixes #515 for now

CMakeLists.txt

@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.16)
 
 # Updating the version here will update it throughout ImHex as well
-set(IMHEX_VERSION "1.18.0")
+set(IMHEX_VERSION "1.18.1")
 project(imhex VERSION ${IMHEX_VERSION})
 
 set(CMAKE_CXX_STANDARD 20)

lib/libimhex/include/hex/helpers/encoding_file.hpp

@@ -2,9 +2,19 @@
 
 #include <hex.hpp>
 
-#include <map>
-#include <string_view>
-#include <vector>
+// TODO: Workaround for weird issue picked up by GCC 12.1.0 and later. This seems like a compiler bug mentioned in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98465
+#pragma GCC diagnostic push
+
+    #if (__GNUC__ >= 12)
+        #pragma GCC diagnostic ignored "-Wrestrict"
+        #pragma GCC diagnostic ignored "-Wstringop-overread"
+    #endif
+
+    #include <map>
+    #include <string_view>
+    #include <vector>
+
+#pragma GCC diagnostic pop
 
 #include <hex/helpers/fs.hpp>
 #include <hex/helpers/file.hpp>

lib/libimhex/source/helpers/utils.cpp

@@ -204,11 +204,15 @@ namespace hex {
     }
 
     std::vector<std::string> splitString(const std::string &string, const std::string &delimiter) {
-        size_t start = 0, end;
+        size_t start = 0, end = 0;
         std::string token;
         std::vector<std::string> res;
 
         while ((end = string.find(delimiter, start)) != std::string::npos) {
+            size_t size = end - start;
+            if (start + size > string.length())
+                break;
+
             token = string.substr(start, end - start);
             start = end + delimiter.length();
             res.push_back(token);

main/source/init/tasks.cpp

@@ -178,10 +178,6 @@ namespace hex::init {
         ImHexApi::HexEditor::impl::getForegroundHighlightingFunctions().clear();
         ImHexApi::HexEditor::impl::getTooltips().clear();
 
-        while (ImHexApi::Provider::isValid())
-            ImHexApi::Provider::remove(ImHexApi::Provider::get());
-        ContentRegistry::Provider::getEntries().clear();
-
         ContentRegistry::Settings::getEntries().clear();
         ContentRegistry::Settings::getSettingsData().clear();
 
@@ -217,6 +213,10 @@ namespace hex::init {
         ContentRegistry::DataFormatter::getEntries().clear();
         ContentRegistry::FileHandler::getEntries().clear();
 
+        while (ImHexApi::Provider::isValid())
+            ImHexApi::Provider::remove(ImHexApi::Provider::get());
+        ContentRegistry::Provider::getEntries().clear();
+
         return true;
     }
 

plugins/builtin/source/content/main_menu_items.cpp

@@ -257,7 +257,7 @@ namespace hex::plugin::builtin {
             if (ImGui::MenuItem("hex.builtin.menu.edit.bookmark"_lang, nullptr, false, selection.has_value() && providerValid)) {
                 auto base = provider->getBaseAddress();
 
-                ImHexApi::Bookmarks::add(base + selection->getStartAddress(), selection->getEndAddress(), {}, {});
+                ImHexApi::Bookmarks::add(base + selection->getStartAddress(), selection->size, {}, {});
             }
         });
 

plugins/builtin/source/content/views/view_hex_editor.cpp

@@ -845,7 +845,7 @@ namespace hex::plugin::builtin {
                             }
 
                             // If the cursor is off-screen, directly jump to the byte
-                            {
+                            if (!ImGui::IsMouseDown(ImGuiMouseButton_Left)) {
                                 const auto newSelection = this->getSelection();
                                 if (newSelection.getStartAddress() < u64(clipper.DisplayStart * this->m_bytesPerRow))
                                     this->jumpToSelection();