imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-27 23:37:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Heap buffer read overflow when inserting bytes

Browse Source
This commit is contained in:
WerWolv
2026-01-24 22:59:30 +01:00
parent 96a5a5d34c
commit fc38c27769
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/libimhex/source/providers/provider.cpp
View File

@@ -133,7 +133,6 @@ namespace hex::prv {
this->resizeRaw(newSize);
std::vector<u8> buffer(0x1000, 0x00);
const std::vector<u8> zeroBuffer(0x1000, 0x00);
auto position = oldSize;
while (position > offset) {
@@ -142,9 +141,18 @@ namespace hex::prv {
position -= readSize;
this->readRaw(position, buffer.data(), readSize);
this->writeRaw(position, zeroBuffer.data(), newSize - oldSize);
this->writeRaw(position + size, buffer.data(), readSize);
}
constexpr static std::array<u8, 0x1000> ZeroBuffer = {};
auto zeroPosition = offset;
auto remainingZeros = size;
while (remainingZeros > 0) {
const auto writeSize = std::min<size_t>(remainingZeros, ZeroBuffer.size());
this->writeRaw(zeroPosition, ZeroBuffer.data(), writeSize);
zeroPosition += writeSize;
remainingZeros -= writeSize;
}
}
void Provider::removeRaw(u64 offset, u64 size) {