fix: Actually fix dropdown default values

This commit is contained in:
WerWolv
2023-10-22 17:51:00 +02:00
parent c51db87c34
commit c3825fff65
3 changed files with 5 additions and 3 deletions

View File

@@ -205,7 +205,7 @@ namespace hex {
std::vector<nlohmann::json> m_settingsValues;
nlohmann::json m_defaultItem;
int m_value = 0;
int m_value = -1;
};
class TextBox : public Widget {
public:

View File

@@ -308,8 +308,10 @@ namespace hex {
}
nlohmann::json DropDown::store() {
if (this->m_value == -1)
return this->m_defaultItem;
if (size_t(this->m_value) >= this->m_items.size())
return nullptr;
return this->m_defaultItem;
return this->m_settingsValues[this->m_value];
}

View File

@@ -237,7 +237,7 @@ namespace hex::plugin::builtin {
languageCodes.emplace_back(languageCode);
}
ContentRegistry::Settings::add<Widgets::DropDown>("hex.builtin.setting.interface", "", "hex.builtin.setting.interface.language", languageNames, languageCodes, LangEntry::getFallbackLanguage());
ContentRegistry::Settings::add<Widgets::DropDown>("hex.builtin.setting.interface", "", "hex.builtin.setting.interface.language", languageNames, languageCodes, "en-US");
ContentRegistry::Settings::add<Widgets::TextBox>("hex.builtin.setting.interface", "", "hex.builtin.setting.interface.wiki_explain_language", "en");
ContentRegistry::Settings::add<FPSWidget>("hex.builtin.setting.interface", "", "hex.builtin.setting.interface.fps");