imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-28 07:47:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

impr: Optimize hovering over patterns in the hex editor

Browse Source
This commit is contained in:
WerWolv
2024-08-03 16:50:30 +02:00
parent a7115d4300
commit 60663babc8
5 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/external/pattern_language vendored

Submodule lib/external/pattern_language updated: 44204e27ce...910b36a857

4
plugins/builtin/source/content/views/view_hex_editor.cpp
View File

@@ -521,6 +521,10 @@ namespace hex::plugin::builtin {
m_hexEditor.setHoverChangedCallback([this](u64 address, size_t size) {
m_hoverHighlights->clear();
if (Region(address, size) == Region::Invalid())
return;
for (const auto &[id, hoverFunction] : ImHexApi::HexEditor::impl::getHoveringFunctions()) {
auto highlightedAddresses = hoverFunction(m_hexEditor.getProvider(), address, size);
m_hoverHighlights->merge(highlightedAddresses);

2
plugins/builtin/source/content/views/view_pattern_editor.cpp
View File

@@ -555,7 +555,7 @@ namespace hex::plugin::builtin {
if (m_hasUnevaluatedChanges && m_runningEvaluators == 0 && m_runningParsers == 0) {
m_hasUnevaluatedChanges = false;
auto code = m_textEditor.GetText();
const auto &code = m_textEditor.GetText();
EventPatternEditorChanged::post(code);
TaskManager::createBackgroundTask("hex.builtin.task.parsing_pattern"_lang, [this, code, provider](auto &){

1
plugins/ui/include/ui/hex_editor.hpp
View File

@@ -333,6 +333,7 @@ namespace hex::ui {
ScrollPosition m_scrollPosition;
Region m_frameStartSelectionRegion = Region::Invalid();
Region m_hoveredRegion = Region::Invalid();
u16 m_bytesPerRow = 16;
std::endian m_dataVisualizerEndianness = std::endian::little;

8
plugins/ui/source/ui/hex_editor.cpp
View File

@@ -669,7 +669,6 @@ namespace hex::ui {
Region newHoveredCell = { byteAddress, bytesPerCell };
if (hoveredCell != newHoveredCell) {
hoveredCell = newHoveredCell;
m_hoverChangedCallback(hoveredCell.address, hoveredCell.size);
}
}
@@ -732,7 +731,6 @@ namespace hex::ui {
Region newHoveredCell = { byteAddress, bytesPerCell };
if (hoveredCell != newHoveredCell) {
hoveredCell = newHoveredCell;
m_hoverChangedCallback(hoveredCell.address, hoveredCell.size);
}
}
@@ -824,7 +822,6 @@ namespace hex::ui {
Region newHoveredCell = { address, data.advance };
if (hoveredCell != newHoveredCell) {
hoveredCell = newHoveredCell;
m_hoverChangedCallback(hoveredCell.address, hoveredCell.size);
}
}
}
@@ -905,6 +902,11 @@ namespace hex::ui {
ImHexApi::HexEditor::impl::setHoveredRegion(m_provider, hoveredCell);
if (m_hoveredRegion != hoveredCell) {
m_hoveredRegion = hoveredCell;
m_hoverChangedCallback(m_hoveredRegion.address, m_hoveredRegion.size);
}
m_shouldScrollToSelection = false;
}