imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-28 07:47:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

Issue 2196 disassembler upper bound (#2272)

Browse Source 
Issue #2196: Disassembler region range upper bound not inclusive

### Problem description
The issue is described
[here](https://github.com/WerWolv/ImHex/issues/2196)

### Implementation description
Some off by 1s

Co-authored-by: paxcut <53811119+paxcut@users.noreply.github.com>
This commit is contained in:
Stephen Hewitt
2025-06-24 20:51:20 +10:00
committed by GitHub
parent df3b85765d
commit 4c20ceb94e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/disassembler/source/content/views/view_disassembler.cpp
View File

@@ -68,9 +68,9 @@ namespace hex::plugin::disasm {
u64 instructionDataAddress = region.getStartAddress();
bool hadError = false;
while (instructionDataAddress < region.getEndAddress()) {
while (instructionDataAddress <= region.getEndAddress()) {
// Read a chunk of data
size_t bufferSize = std::min<u64>(buffer.size(), (region.getEndAddress() - instructionDataAddress));
size_t bufferSize = std::min<u64>(buffer.size(), (region.getEndAddress()-instructionDataAddress)+1);
provider->read(instructionDataAddress, buffer.data(), bufferSize);
auto code = std::span(buffer.data(), bufferSize);