imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-28 07:47:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Crash when using paste without a valid selection

Browse Source
This commit is contained in:
WerWolv
2023-06-26 11:14:10 +02:00
parent cda883bb0f
commit 15cd2b693c
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/builtin/source/content/views/view_hex_editor.cpp
View File

@@ -574,6 +574,7 @@ namespace hex::plugin::builtin {
ViewHexEditor::~ViewHexEditor() {
EventManager::unsubscribe<EventProviderChanged>(this);
EventManager::unsubscribe<EventProviderOpened>(this);
}
void ViewHexEditor::drawPopup() {
@@ -917,6 +918,10 @@ namespace hex::plugin::builtin {
}
});
EventManager::subscribe<EventProviderOpened>(this, [](auto *) {
ImHexApi::HexEditor::clearSelection();
});
ProjectFile::registerPerProviderHandler({
.basePath = "custom_encoding.tbl",
.required = false,
@@ -1097,7 +1102,7 @@ namespace hex::plugin::builtin {
/* Paste */
ContentRegistry::Interface::addMenuItem({ "hex.builtin.menu.edit", "hex.builtin.view.hex_editor.menu.edit.paste" }, 1450, CurrentView + CTRLCMD + Keys::V,
[] {
pasteBytes(*ImHexApi::HexEditor::getSelection(), true);
pasteBytes(ImHexApi::HexEditor::getSelection().value_or( ImHexApi::HexEditor::ProviderRegion(Region { 0, 0 }, ImHexApi::Provider::get())), true);
},
ImHexApi::HexEditor::isSelectionValid,
this);
@@ -1105,7 +1110,7 @@ namespace hex::plugin::builtin {
/* Paste All */
ContentRegistry::Interface::addMenuItem({ "hex.builtin.menu.edit", "hex.builtin.view.hex_editor.menu.edit.paste_all" }, 1500, CurrentView + CTRLCMD + SHIFT + Keys::V,
[] {
pasteBytes(*ImHexApi::HexEditor::getSelection(), false);
pasteBytes(ImHexApi::HexEditor::getSelection().value_or( ImHexApi::HexEditor::ProviderRegion(Region { 0, 0 }, ImHexApi::Provider::get())), false);
},
ImHexApi::HexEditor::isSelectionValid,
this);