imports/architectury-loom
1
0
Fork 0
mirror of https://github.com/architectury/architectury-loom.git synced 2026-03-28 04:07:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Validate jar and fail if it was built with Loom 1.5 or later.

Browse Source
This commit is contained in:
modmuss
2024-01-04 14:09:25 +00:00
committed by shedaniel
parent 93bf2869f1
commit 0f894aa23d
2 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/net/fabricmc/loom/build/ModCompileRemapper.java
View File

@@ -26,6 +26,7 @@ package net.fabricmc.loom.build;
import java.io.File;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.util.ArrayList;
import java.util.List;
import java.util.function.Supplier;
@@ -91,6 +92,12 @@ public class ModCompileRemapper {
String name = artifact.getModuleVersion().getId().getName();
String version = replaceIfNullOrEmpty(artifact.getModuleVersion().getId().getVersion(), () -> Checksum.truncatedSha256(artifact.getFile()));
try {
ModUtils.validateJarManifest(artifact.getFile().toPath());
} catch (IOException e) {
throw new UncheckedIOException("Failed to read manifest from" + artifact.getFile(), e);
}
if (!ModUtils.shouldRemapMod(project.getLogger(), artifact.getFile(), artifact.getId(), extension.getPlatform().get(), sourceConfig.getName())) {
addToRegularCompile(project, regularConfig, artifact);
continue;

21
src/main/java/net/fabricmc/loom/util/ModUtils.java
View File

@@ -24,11 +24,15 @@
package net.fabricmc.loom.util;
import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.jar.Attributes;
import java.util.jar.Manifest;
import com.google.gson.JsonObject;
import org.gradle.api.logging.Logger;
@@ -82,4 +86,21 @@ public final class ModUtils {
return false;
}
public static void validateJarManifest(Path path) throws IOException {
try (FileSystemUtil.Delegate fs = FileSystemUtil.getJarFileSystem(path)) {
final Path manifestPath = fs.get().getPath("META-INF/MANIFEST.MF");
if (Files.exists(manifestPath)) {
final var manifest = new Manifest(new ByteArrayInputStream(Files.readAllBytes(manifestPath)));
final Attributes mainAttributes = manifest.getMainAttributes();
// Check to see if the jar was built with a newer version of loom.
// This version of loom does not support the remap type value so throw an exception.
if (mainAttributes.getValue("Fabric-Loom-Mixin-Remap-Type") != null) {
throw new IllegalStateException("This version of loom does not support the mixin remap type value. Please update to the latest version of loom.");
}
}
}
}
}