imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-28 07:47:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Writing not working correctly through a provider view

Browse Source
This commit is contained in:
WerWolv
2025-02-07 15:45:38 +01:00
parent a588c96440
commit ed6da7fe14
3 changed files with 44 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/builtin/include/content/providers/view_provider.hpp
View File

@@ -23,6 +23,8 @@ namespace hex::plugin::builtin {
void resizeRaw(u64 newSize) override;
void insertRaw(u64 offset, u64 size) override;
void removeRaw(u64 offset, u64 size) override;
void read(u64 offset, void *buffer, size_t size, bool overlays = true) override;
void write(u64 offset, const void *buffer, size_t size) override;
void readRaw(u64 offset, void *buffer, size_t size) override;
void writeRaw(u64 offset, const void *buffer, size_t size) override;
@@ -35,6 +37,16 @@ namespace hex::plugin::builtin {
void loadSettings(const nlohmann::json &settings) override;
[[nodiscard]] nlohmann::json storeSettings(nlohmann::json settings) const override;
u64 getBaseAddress() const override {
u64 result = m_startAddress;
if (m_provider != nullptr)
result += m_provider->getBaseAddress();
return result;
}
void setBaseAddress(u64 address) override { std::ignore = address; }
void setProvider(u64 startAddress, size_t size, hex::prv::Provider *provider);
void setName(const std::string &name);
@@ -43,6 +55,12 @@ namespace hex::plugin::builtin {
std::vector<MenuEntry> getMenuEntries() override;
void undo() override { if (m_provider != nullptr) m_provider->undo(); }
void redo() override { if (m_provider != nullptr) m_provider->redo(); }
bool canUndo() const override { return m_provider != nullptr && m_provider->canUndo(); }
bool canRedo() const override { return m_provider != nullptr && m_provider->canRedo(); }
private:
void renameFile();

24
plugins/builtin/source/content/providers/view_provider.cpp
View File

@@ -29,7 +29,7 @@ namespace hex::plugin::builtin {
return m_provider->isWritable();
}
[[nodiscard]] bool ViewProvider::isResizable() const {
return true;
return false;
}
[[nodiscard]] bool ViewProvider::isSavable() const {
@@ -71,7 +71,7 @@ namespace hex::plugin::builtin {
return;
m_size += size;
m_provider->insert(offset + m_startAddress, size);
m_provider->insert(offset, size);
}
void ViewProvider::removeRaw(u64 offset, u64 size) {
@@ -79,21 +79,35 @@ namespace hex::plugin::builtin {
return;
m_size -= size;
m_provider->remove(offset + m_startAddress, size);
m_provider->remove(offset, size);
}
void ViewProvider::read(u64 offset, void *buffer, size_t size, bool overlays) {
if (m_provider == nullptr)
return;
m_provider->read(offset, buffer, size, overlays);
}
void ViewProvider::write(u64 offset, const void *buffer, size_t size) {
if (m_provider == nullptr)
return;
m_provider->write(offset, buffer, size);
}
void ViewProvider::readRaw(u64 offset, void *buffer, size_t size) {
if (m_provider == nullptr)
return;
m_provider->read(offset + m_startAddress, buffer, size);
m_provider->readRaw(offset, buffer, size);
}
void ViewProvider::writeRaw(u64 offset, const void *buffer, size_t size) {
if (m_provider == nullptr)
return;
m_provider->write(offset + m_startAddress, buffer, size);
m_provider->writeRaw(offset, buffer, size);
}
[[nodiscard]] u64 ViewProvider::getActualSize() const {