From e865883611751f9c31b5deda3d4e8ee395cb8a20 Mon Sep 17 00:00:00 2001 From: Nik Date: Sun, 2 Oct 2022 17:31:40 +0200 Subject: [PATCH] git: Remove msi signing again since Microsoft doesn't care at all (#765) --- .github/workflows/build.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 378464938..22bbf875f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -101,16 +101,16 @@ jobs: cpack echo "ImHex checks for the existence of this file to determine if it is running in portable mode. You should not delete this file" > $PWD/install/PORTABLE - - name: 🗝️ Sign Windows Installer - if: github.event_name == 'push' && github.ref == 'refs/heads/master' - shell: powershell - env: - WIN_SIGN_CERT: ${{ secrets.WIN_SIGN_CERT }} - WIN_SIGN_PW: ${{ secrets.WIN_SIGN_PW }} - run: | - $buffer = [System.Convert]::FromBase64String($env:WIN_SIGN_CERT) - $certificate = [System.Security.Cryptography.X509Certificates.X509Certificate2]::New($buffer, $env:WIN_SIGN_PW) - Get-ChildItem -Path ./build -Filter *.msi -Recurse | Set-AuthenticodeSignature -HashAlgorithm SHA256 -Certificate $certificate -TimestampServer http://timestamp.digicert.com + #- name: 🗝️ Sign Windows Installer + # if: github.event_name == 'push' && github.ref == 'refs/heads/master' + # shell: powershell + # env: + # WIN_SIGN_CERT: ${{ secrets.WIN_SIGN_CERT }} + # WIN_SIGN_PW: ${{ secrets.WIN_SIGN_PW }} + # run: | + # $buffer = [System.Convert]::FromBase64String($env:WIN_SIGN_CERT) + # $certificate = [System.Security.Cryptography.X509Certificates.X509Certificate2]::New($buffer, $env:WIN_SIGN_PW) + # Get-ChildItem -Path ./build -Filter *.msi -Recurse | Set-AuthenticodeSignature -HashAlgorithm SHA256 -Certificate $certificate -TimestampServer http://timestamp.digicert.com - name: ⬆️ Upload Windows Installer uses: actions/upload-artifact@v3