From e2b7a69fc8d1be97d9165cacc07f17e603748b58 Mon Sep 17 00:00:00 2001 From: WerWolv Date: Sun, 31 Dec 2023 13:53:28 +0100 Subject: [PATCH] fix: Warnings when trying to load progress for achievements that aren't in save file --- lib/libimhex/source/api/achievement_manager.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/libimhex/source/api/achievement_manager.cpp b/lib/libimhex/source/api/achievement_manager.cpp index 41c53c383..47232f0a3 100644 --- a/lib/libimhex/source/api/achievement_manager.cpp +++ b/lib/libimhex/source/api/achievement_manager.cpp @@ -201,7 +201,11 @@ namespace hex { for (const auto &[categoryName, achievements] : getAchievements()) { for (const auto &[achievementName, achievement] : achievements) { try { - achievement->setProgress(json[categoryName][achievementName]); + const auto &progress = json[categoryName][achievementName]; + if (progress.is_null()) + continue; + + achievement->setProgress(progress); } catch (const std::exception &e) { log::warn("Failed to load achievement progress for '{}::{}': {}", categoryName, achievementName, e.what()); }