patterns: Disallow application/octet-stream to be used as MIME type

This commit is contained in:
WerWolv
2023-01-09 08:38:19 +01:00
parent c1359a71d6
commit dbcb13f473
4 changed files with 23 additions and 5 deletions

View File

@@ -1,5 +1,6 @@
#include <hex/api/content_registry.hpp>
#include <hex/providers/provider.hpp>
#include <hex/helpers/magic.hpp>
#include <pl/core/evaluator.hpp>
@@ -8,8 +9,6 @@ namespace hex::plugin::builtin {
void registerPatternLanguagePragmas() {
ContentRegistry::PatternLanguage::addPragma("base_address", [](pl::PatternLanguage &runtime, const std::string &value) {
hex::unused(runtime);
auto baseAddress = strtoull(value.c_str(), nullptr, 0);
ImHexApi::Provider::get()->setBaseAddress(baseAddress);
@@ -18,7 +17,9 @@ namespace hex::plugin::builtin {
return true;
});
ContentRegistry::PatternLanguage::addPragma("MIME", [](pl::PatternLanguage&, const std::string &value) { return !value.empty(); });
ContentRegistry::PatternLanguage::addPragma("MIME", [](pl::PatternLanguage&, const std::string &value) {
return magic::isValidMIMEType(value);
});
}
}

View File

@@ -773,6 +773,9 @@ namespace hex::plugin::builtin {
runtime->addPragma("MIME", [&mimeType, &foundCorrectType](pl::PatternLanguage &runtime, const std::string &value) {
hex::unused(runtime);
if (!magic::isValidMIMEType(value))
return false;
if (value == mimeType) {
foundCorrectType = true;
return true;
@@ -802,8 +805,6 @@ namespace hex::plugin::builtin {
}
}
runtime->addPragma("MIME", [](pl::PatternLanguage&, const std::string &value) { return !value.empty(); });
if (!this->m_possiblePatternFiles.empty()) {
this->m_selectedPatternFile = 0;
EventManager::post<RequestOpenPopup>("hex.builtin.view.pattern_editor.accept_pattern"_lang);