imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-29 00:10:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

impr: Refactoring of floating point tool to decrease code complexity. (#1275)

Browse Source 
I noticed the bad score on code factor so I reorganized it to make it
more readable and maintainable. In order to break down the big function
into it much smaller parts I encapsulated all the variables that the
functions need to access in two classes, one for the imgui related
statics and the other for non-static variables.

When writing the smaller functions I was noticed that there was room to
simplify the existing algorithms by writing functions that could be
called by parts that previously shared no code. I tested the changes the
same way I tested the original and it seems to work the same way but
maybe a bit faster. Although it may be possible to further optimize the
present code code factor no longer flags the function at all.
This commit is contained in:
paxcut
2023-09-20 01:48:44 -07:00
committed by GitHub
parent ad69ac84b1
commit c577a42f62
4 changed files with 557 additions and 507 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/libimhex/source/data_processor/node.cpp
View File

@@ -64,7 +64,7 @@ namespace hex::dp {
return *reinterpret_cast<i128 *>(outputData.data());
}
const long double& Node::getFloatOnInput(u32 index) {
const double& Node::getFloatOnInput(u32 index) {
auto attribute = this->getConnectedInputAttribute(index);
auto &outputData = [&] -> std::vector<u8>& {
@@ -84,10 +84,10 @@ namespace hex::dp {
if (outputData.empty())
throwNodeError("No data available at connected attribute");
if (outputData.size() < sizeof(long double))
if (outputData.size() < sizeof(double))
throwNodeError("Not enough data provided for float");
return *reinterpret_cast<long double *>(outputData.data());
return *reinterpret_cast<double *>(outputData.data());
}
void Node::setBufferOnOutput(u32 index, std::span<const u8> data) {
@@ -123,7 +123,7 @@ namespace hex::dp {
attribute.getOutputData() = buffer;
}
void Node::setFloatOnOutput(u32 index, long double floatingPoint) {
void Node::setFloatOnOutput(u32 index, double floatingPoint) {
if (index >= this->getAttributes().size())
throwNodeError("Attribute index out of bounds!");