imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-27 23:37:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Semantic version comparison only working in one direction

Browse Source
This commit is contained in:
WerWolv
2025-08-23 11:03:57 +02:00
parent 393451eed5
commit ba71a300ec
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
lib/libimhex/source/helpers/semantic_version.cpp
View File

@@ -92,19 +92,19 @@ namespace hex {
}
std::strong_ordering SemanticVersion::operator<=>(const SemanticVersion &other) const {
if (*this == other)
return std::strong_ordering::equivalent;
if (const auto result = major() <=> other.major(); result != std::strong_ordering::equal)
return result;
if (auto result = minor() <=> other.minor(); result != std::strong_ordering::equal)
return result;
if (auto result = patch() <=> other.patch(); result != std::strong_ordering::equal)
return result;
if (this->major() > other.major())
return std::strong_ordering::greater;
if (this->minor() > other.minor())
return std::strong_ordering::greater;
if (this->patch() > other.patch())
return std::strong_ordering::greater;
if (!this->nightly() && other.nightly())
return std::strong_ordering::greater;
// nightly builds are considered "greater" than release builds
if (nightly() != other.nightly())
return nightly() ? std::strong_ordering::greater
: std::strong_ordering::less;
return std::strong_ordering::less;
return std::strong_ordering::equal;
}
std::string SemanticVersion::get(bool withBuildType) const {