From af77819913b0d1d260d4e72121bc21c0c2f68006 Mon Sep 17 00:00:00 2001 From: WerWolv Date: Sat, 11 Nov 2023 23:43:32 +0100 Subject: [PATCH] fix: Crash when choosing File -> Select without an active selection --- plugins/builtin/source/content/views/view_hex_editor.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/builtin/source/content/views/view_hex_editor.cpp b/plugins/builtin/source/content/views/view_hex_editor.cpp index 9e53d5023..e4b0f5fa4 100644 --- a/plugins/builtin/source/content/views/view_hex_editor.cpp +++ b/plugins/builtin/source/content/views/view_hex_editor.cpp @@ -1113,8 +1113,8 @@ namespace hex::plugin::builtin { ContentRegistry::Interface::addMenuItem({ "hex.builtin.menu.file", "hex.builtin.view.hex_editor.menu.file.select" }, 1650, CTRLCMD + SHIFT + Keys::A, [this] { - auto selection = ImHexApi::HexEditor::getSelection(); - this->openPopup(selection->getStartAddress(), selection->getSize()); + auto selection = ImHexApi::HexEditor::getSelection().value_or(ImHexApi::HexEditor::ProviderRegion{ { 0, 1 }, nullptr }); + this->openPopup(selection.getStartAddress(), selection.getSize()); }, ImHexApi::Provider::isValid);