From a4d6932ed8f30447d2daef58dcce717874e37f35 Mon Sep 17 00:00:00 2001 From: iTrooz Date: Fri, 26 Jan 2024 19:44:52 +0100 Subject: [PATCH] fix: remove TODO + show error message when reading/write in process provider (#1516) --- main/gui/source/messaging/win.cpp | 2 -- .../source/content/providers/process_memory_provider.cpp | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/main/gui/source/messaging/win.cpp b/main/gui/source/messaging/win.cpp index be08b03fc..684f04a12 100644 --- a/main/gui/source/messaging/win.cpp +++ b/main/gui/source/messaging/win.cpp @@ -45,8 +45,6 @@ namespace hex::messaging { HWND imHexWindow = *getImHexWindow(); // Create the message - // TODO actually send all arguments and not just the eventName - std::vector fulleventData(eventName.begin(), eventName.end()); fulleventData.push_back('\0'); diff --git a/plugins/builtin/source/content/providers/process_memory_provider.cpp b/plugins/builtin/source/content/providers/process_memory_provider.cpp index bb338dc41..8cee45d2f 100644 --- a/plugins/builtin/source/content/providers/process_memory_provider.cpp +++ b/plugins/builtin/source/content/providers/process_memory_provider.cpp @@ -63,7 +63,7 @@ namespace hex::plugin::builtin { auto read = process_vm_readv(m_processId, &local, 1, &remote, 1, 0); if (read == -1) { - // TODO error handling strerror(errno) + log::error("Process memory provider failed to read data: {}", strerror(errno)); } #endif } @@ -82,7 +82,7 @@ namespace hex::plugin::builtin { auto read = process_vm_writev(m_processId, &local, 1, &remote, 1, 0); if (read == -1) { - // TODO error handling strerror(errno) + log::error("Process memory provider failed to write data: {}", strerror(errno)); } #endif }