imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-04-02 05:27:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

impr: Remove hex::format, improve format and logging type safety

Browse Source
This commit is contained in:
WerWolv
2025-08-06 20:01:58 +02:00
parent d429424f67
commit 9cff9043ee
109 changed files with 473 additions and 455 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/builtin/include/content/popups/popup_crash_recovered.hpp
View File

@@ -19,7 +19,7 @@ namespace hex::plugin::builtin {
void drawContent() override {
ImGuiExt::TextFormattedWrapped("hex.builtin.popup.crash_recover.message"_lang);
ImGuiExt::TextFormattedWrapped(hex::format("Error: {}: {}", trace::demangle(this->m_errorType), this->m_errorMessage));
ImGuiExt::TextFormattedWrapped(fmt::format("Error: {}: {}", trace::demangle(this->m_errorType), this->m_errorMessage));
if (ImGui::Button("hex.ui.common.okay"_lang)) {
this->close();

2
plugins/builtin/include/content/popups/popup_docs_question.hpp
View File

@@ -90,7 +90,7 @@ namespace hex::plugin::builtin {
for (auto space : { "xj7sbzGbHH260vbpZOu1", "WZzDdGjxmgMSIE3xly6o" }) {
m_answer.clear();
auto request = HttpRequest("POST", hex::format("https://api.gitbook.com/v1/spaces/{}/search/ask", space));
auto request = HttpRequest("POST", fmt::format("https://api.gitbook.com/v1/spaces/{}/search/ask", space));
// Documentation API often takes a long time to respond, so we set a timeout of 30 seconds
request.setTimeout(30'000);

2
plugins/builtin/include/content/providers/process_memory_provider.hpp
View File

@@ -50,7 +50,7 @@ namespace hex::plugin::builtin {
void save() override {}
[[nodiscard]] std::string getName() const override { return hex::format("hex.builtin.provider.process_memory.name"_lang, m_selectedProcess != nullptr ? m_selectedProcess->name : ""); }
[[nodiscard]] std::string getName() const override { return fmt::format("hex.builtin.provider.process_memory.name"_lang, m_selectedProcess != nullptr ? m_selectedProcess->name : ""); }
[[nodiscard]] std::vector<Description> getDataDescription() const override {
return {
{ "hex.builtin.provider.process_memory.process_name"_lang, m_selectedProcess->name },

2
plugins/builtin/include/content/providers/udp_provider.hpp
View File

@@ -39,7 +39,7 @@ namespace hex::plugin::builtin {
return "hex.builtin.provider.udp";
}
std::string getName() const override { return hex::format("hex.builtin.provider.udp.name"_lang, m_port); }
std::string getName() const override { return fmt::format("hex.builtin.provider.udp.name"_lang, m_port); }
protected:
void receive(std::span<const u8> data);

2
plugins/builtin/include/content/providers/undo_operations/operation_bookmark.hpp
View File

@@ -26,7 +26,7 @@ namespace hex::plugin::builtin::undo {
}
[[nodiscard]] std::string format() const override {
return hex::format("Bookmark {} created", m_entry.name);
return fmt::format("Bookmark {} created", m_entry.name);
}
std::unique_ptr<Operation> clone() const override {

2
plugins/builtin/include/content/providers/undo_operations/operation_insert.hpp
View File

@@ -21,7 +21,7 @@ namespace hex::plugin::builtin::undo {
}
[[nodiscard]] std::string format() const override {
return hex::format("hex.builtin.undo_operation.insert"_lang, hex::toByteString(m_size), m_offset);
return fmt::format("hex.builtin.undo_operation.insert"_lang, hex::toByteString(m_size), m_offset);
}
std::unique_ptr<Operation> clone() const override {

2
plugins/builtin/include/content/providers/undo_operations/operation_remove.hpp
View File

@@ -26,7 +26,7 @@ namespace hex::plugin::builtin::undo {
}
[[nodiscard]] std::string format() const override {
return hex::format("hex.builtin.undo_operation.remove"_lang, hex::toByteString(m_size), m_offset);
return fmt::format("hex.builtin.undo_operation.remove"_lang, hex::toByteString(m_size), m_offset);
}
std::unique_ptr<Operation> clone() const override {

4
plugins/builtin/include/content/providers/undo_operations/operation_write.hpp
View File

@@ -26,12 +26,12 @@ namespace hex::plugin::builtin::undo {
}
[[nodiscard]] std::string format() const override {
return hex::format("hex.builtin.undo_operation.write"_lang, hex::toByteString(m_newData.size()), m_offset);
return fmt::format("hex.builtin.undo_operation.write"_lang, hex::toByteString(m_newData.size()), m_offset);
}
std::vector<std::string> formatContent() const override {
return {
hex::format("{} {} {}", hex::crypt::encode16(m_oldData), ICON_VS_ARROW_RIGHT, hex::crypt::encode16(m_newData)),
fmt::format("{} {} {}", hex::crypt::encode16(m_oldData), ICON_VS_ARROW_RIGHT, hex::crypt::encode16(m_newData)),
};
}

2
plugins/builtin/include/content/views/view_pattern_editor.hpp
View File

@@ -419,7 +419,7 @@ namespace hex::plugin::builtin {
literal = std::get<pl::core::Token::Literal>(it->value);
string = std::get_if<std::string>(&literal);
if (string != nullptr) {
m_patternNames[path] = hex::format("{} ({})", *string, fileName);
m_patternNames[path] = fmt::format("{} ({})", *string, fileName);
}
}
}