imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-04-02 13:37:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Open file in explorer not working on Windows

Browse Source
This commit is contained in:
WerWolv
2025-07-31 00:24:54 +02:00
parent 1804caba02
commit 9557041c3a
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/libimhex/source/helpers/fs.cpp
View File

@@ -44,14 +44,16 @@ namespace hex::fs {
}
// With help from https://github.com/owncloud/client/blob/cba22aa34b3677406e0499aadd126ce1d94637a2/src/gui/openfilemanager.cpp
void openFileExternal(const std::fs::path &filePath) {
void openFileExternal(std::fs::path filePath) {
filePath.make_preferred();
// Make sure the file exists before trying to open it
if (!wolv::io::fs::exists(filePath)) {
return;
}
#if defined(OS_WINDOWS)
std::ignore = ShellExecuteW(nullptr, L"open", filePath.c_str(), nullptr, nullptr, SW_SHOWNORMAL);
std::ignore = ShellExecuteW(nullptr, L"open", filePath.c_str(), nullptr, nullptr, SW_SHOWNORMAL);
#elif defined(OS_MACOS)
std::ignore = system(
hex::format("open {}", wolv::util::toUTF8String(filePath)).c_str()
@@ -61,7 +63,9 @@ namespace hex::fs {
#endif
}
void openFolderExternal(const std::fs::path &dirPath) {
void openFolderExternal(std::fs::path dirPath) {
dirPath.make_preferred();
// Make sure the folder exists before trying to open it
if (!wolv::io::fs::exists(dirPath)) {
return;
@@ -79,7 +83,9 @@ namespace hex::fs {
#endif
}
void openFolderWithSelectionExternal(const std::fs::path &selectedFilePath) {
void openFolderWithSelectionExternal(std::fs::path selectedFilePath) {
selectedFilePath.make_preferred();
// Make sure the file exists before trying to open it
if (!wolv::io::fs::exists(selectedFilePath)) {
return;