From 92c2018f714f1093418be69932a7afb54fb3569f Mon Sep 17 00:00:00 2001 From: WerWolv Date: Tue, 18 Feb 2025 15:22:29 +0100 Subject: [PATCH] fix: Prevent stack overread when calling dbus-send --- main/gui/source/window/linux_window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/gui/source/window/linux_window.cpp b/main/gui/source/window/linux_window.cpp index 5bc792471..53ad0788c 100644 --- a/main/gui/source/window/linux_window.cpp +++ b/main/gui/source/window/linux_window.cpp @@ -161,7 +161,7 @@ namespace hex { FILE *pipe = popen("dbus-send --session --print-reply --dest=org.freedesktop.portal.Desktop /org/freedesktop/portal/desktop org.freedesktop.portal.Settings.Read string:'org.freedesktop.appearance' string:'color-scheme' 2>&1", "r"); if (pipe == nullptr) return; - while (fgets(buffer.data(), buffer.size(), pipe) != nullptr) + while (fgets(buffer.data(), buffer.size() - 1, pipe) != nullptr) result += buffer.data(); auto exitCode = WEXITSTATUS(pclose(pipe));