imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-30 13:05:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

nodes/patterns: Fixed crashes when recursion occurred

Browse Source
This commit is contained in:
WerWolv
2021-03-07 13:20:33 +01:00
parent d4265f16eb
commit 8423f78586
6 changed files with 45 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
plugins/libimhex/include/hex/data_processor/node.hpp
View File

@@ -2,6 +2,9 @@
#include <hex/data_processor/attribute.hpp>
#include <set>
#include <vector>
namespace hex::dp {
class Node {
@@ -31,10 +34,15 @@ namespace hex::dp {
attribute.getOutputData().reset();
}
void resetProcessedInputs() {
this->m_processedInputs.clear();
}
private:
u32 m_id;
std::string m_unlocalizedName;
std::vector<Attribute> m_attributes;
std::set<u32> m_processedInputs;
prv::Overlay *m_overlay = nullptr;
Attribute* getConnectedInputAttribute(u32 index) {
@@ -49,6 +57,12 @@ namespace hex::dp {
return connectedAttribute.begin()->second;
}
void markInputProcessed(u32 index) {
const auto &[iter, inserted] = this->m_processedInputs.insert(index);
if (!inserted)
throwNodeError("Recursion detected!");
}
protected:
[[noreturn]] void throwNodeError(std::string_view message) {
@@ -64,6 +78,7 @@ namespace hex::dp {
if (attribute->getType() != Attribute::Type::Buffer)
throwNodeError("Tried to read buffer from non-buffer attribute");
markInputProcessed(index);
attribute->getParentNode()->process();
auto &outputData = attribute->getOutputData();
@@ -83,6 +98,7 @@ namespace hex::dp {
if (attribute->getType() != Attribute::Type::Integer)
throwNodeError("Tried to read integer from non-integer attribute");
markInputProcessed(index);
attribute->getParentNode()->process();
auto &outputData = attribute->getOutputData();
@@ -105,6 +121,7 @@ namespace hex::dp {
if (attribute->getType() != Attribute::Type::Float)
throwNodeError("Tried to read float from non-float attribute");
markInputProcessed(index);
attribute->getParentNode()->process();
auto &outputData = attribute->getOutputData();