From 64a30a45d503b90bf21dc0db2951ea5c875e0a4a Mon Sep 17 00:00:00 2001 From: Imron jehleh <60736083+zorone@users.noreply.github.com> Date: Sat, 16 Sep 2023 18:09:24 +0700 Subject: [PATCH] fix: Error popup now showing up immediately after click (#1272) From #1265, Looks like Error Popup doesn't handle properly in some circumstances. --------- Co-authored-by: iTrooz Co-authored-by: WerWolv --- dist/compiling/windows.md | 3 +++ .../builtin/source/content/views/view_provider_settings.cpp | 1 + 2 files changed, 4 insertions(+) diff --git a/dist/compiling/windows.md b/dist/compiling/windows.md index df1556f4f..20a7aa638 100644 --- a/dist/compiling/windows.md +++ b/dist/compiling/windows.md @@ -7,6 +7,7 @@ On Windows, ImHex is built through [msys2 / mingw](https://www.msys2.org/)'s gcc 3. Clone the repo using `git clone https://github.com/WerWolv/ImHex --recurse-submodules` 4. Install all the dependencies using `./ImHex/dist/get_deps_msys2.sh` 5. Build ImHex itself using the following commands: + ```sh cd ImHex mkdir build @@ -20,3 +21,5 @@ ninja install ``` ImHex will look for any extra resources either in various folders directly next to the executable or in `%localappdata%/imhex` + +For low RAM-usage system, you can use `mingw32-make -j N install` instead, to reduce RAM usage at compile time. Where `N` is amount of jobs you are willling to run at once. Roughly ~1 GB of RAM usage per job. diff --git a/plugins/builtin/source/content/views/view_provider_settings.cpp b/plugins/builtin/source/content/views/view_provider_settings.cpp index afa09c313..1580a8326 100644 --- a/plugins/builtin/source/content/views/view_provider_settings.cpp +++ b/plugins/builtin/source/content/views/view_provider_settings.cpp @@ -43,6 +43,7 @@ namespace hex::plugin::builtin { ImGui::CloseCurrentPopup(); } else { + ImGui::CloseCurrentPopup(); auto errorMessage = provider->getErrorMessage(); if (errorMessage.empty()) { PopupError::open("hex.builtin.view.provider_settings.load_error"_lang);