imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-04-02 05:27:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

store: Fixed more download issues when some folders don't have write perms

Browse Source
This commit is contained in:
WerWolv
2022-02-28 23:10:04 +01:00
parent 2847098020
commit 5a02c38fcd
6 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/builtin/source/content/views/view_store.cpp
View File

@@ -110,7 +110,7 @@ namespace hex::plugin::builtin {
downloadDoneCallback(entry);
} else
log::error("Download failed!");
log::error("Download failed! HTTP Code {}", response.code);
this->m_download = {};
@@ -186,7 +186,7 @@ namespace hex::plugin::builtin {
auto path = folder / fs::path(storeEntry.fileName);
if (fs::exists(path)) {
if (fs::exists(path) && hex::isPathWritable(folder)) {
storeEntry.installed = true;
std::ifstream file(path, std::ios::in | std::ios::binary);
@@ -237,7 +237,11 @@ namespace hex::plugin::builtin {
bool ViewStore::download(ImHexPath pathType, const std::string &fileName, const std::string &url, bool update) {
bool downloading = false;
for (const auto &path : hex::getPath(pathType)) {
if (!hex::isPathWritable(path))
continue;
auto fullPath = path / fs::path(fileName);
if (!update || fs::exists(fullPath)) {
downloading = true;
this->m_downloadPath = fullPath;
@@ -257,8 +261,10 @@ namespace hex::plugin::builtin {
bool ViewStore::remove(ImHexPath pathType, const std::string &fileName) {
bool removed = false;
for (const auto &path : hex::getPath(pathType)) {
bool removedFile = fs::remove(path / fs::path(fileName));
bool removedFolder = fs::remove(path / fs::path(fileName).stem());
std::error_code error;
bool removedFile = fs::remove(path / fs::path(fileName), error);
bool removedFolder = fs::remove(path / fs::path(fileName).stem(), error);
removed = removed || removedFile || removedFolder;
}