From 4792a29facbd887b210a86c15c6369bf7a6d553c Mon Sep 17 00:00:00 2001 From: WerWolv Date: Wed, 26 Jul 2023 22:13:39 +0200 Subject: [PATCH] fix: Crash when passing invalid parameters to sound visualizer Fixes #1208 --- plugins/builtin/source/content/pl_visualizers.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/plugins/builtin/source/content/pl_visualizers.cpp b/plugins/builtin/source/content/pl_visualizers.cpp index dd844bcc6..e34d5e2eb 100644 --- a/plugins/builtin/source/content/pl_visualizers.cpp +++ b/plugins/builtin/source/content/pl_visualizers.cpp @@ -378,6 +378,11 @@ namespace hex::plugin::builtin { static u64 index = 0; static TaskHolder resetTask; + if (sampleRate == 0) + throw std::logic_error(hex::format("Invalid sample rate: {}", sampleRate)); + else if (channels == 0) + throw std::logic_error(hex::format("Invalid channel count: {}", channels)); + if (shouldReset) { waveData.clear();