imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-03-30 21:05:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

fixed UB created by erasing map elements in range for loop.

Browse Source
This commit is contained in:
paxcut
2026-03-24 06:43:41 -07:00
parent c677aae7b1
commit 3b2e95b9d0
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
plugins/ui/source/ui/text_editor/render.cpp
View File

@@ -540,17 +540,16 @@ namespace hex::ui {
m_codeFolds.clear();
m_rowToFoldSymbol.clear();
for (auto [key, isOpen]: m_codeFoldState){
auto index = m_codeFoldKeys.find(key);
if (index->m_start != key.m_start || index->m_end != key.m_end)
m_codeFoldState.erase(key);
}
std::erase_if(m_codeFoldState, [this](const auto& entry) {
auto index = m_codeFoldKeys.find(entry.first);
return (index->m_start != entry.first.m_start || index->m_end != entry.first.m_end);
});
std::erase_if(m_codeFoldKeys, [](const auto& entry) {
return (entry.m_start >= entry.m_end);
});
for (auto key : m_codeFoldKeys) {
if (key.m_start >= key.m_end) {
m_codeFoldKeys.erase(key);
continue;
}
auto rowStart = lineIndexToRow(key.m_start.m_line);
auto rowEnd = lineIndexToRow(key.m_end.m_line);