imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-04-02 05:27:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent potential UB using std::clamp.

Browse Source 
### Problem description
It is possible for the maximum and minimum value arguments to std::clamp to be swapped which is defined  in the standard as undefined behavior

### Implementation description
Swap the values if necessary.


---------

Co-authored-by: paxcut <53811119+paxcut@users.noreply.github.com>
This commit is contained in:
ThePirate42
2025-05-05 02:24:59 +02:00
committed by GitHub
parent 4883ed0e5a
commit 36eeee5f9c
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/builtin/source/content/views/view_pattern_editor.cpp
View File

@@ -335,7 +335,11 @@ namespace hex::plugin::builtin {
auto textEditorSize = availableSize;
textEditorSize.y *= 3.5F / 5.0F;
textEditorSize.y -= ImGui::GetTextLineHeightWithSpacing();
textEditorSize.y = std::clamp(textEditorSize.y + height, 200.0F, availableSize.y - 200.0F);
if (200.0F > availableSize.y - 200.0F) {
textEditorSize.y = std::clamp(textEditorSize.y + height, availableSize.y - 200.0F, 200.0F);
} else {
textEditorSize.y = std::clamp(textEditorSize.y + height, 200.0F, availableSize.y - 200.0F);
}
if (g.NavWindow != nullptr) {
std::string name = g.NavWindow->Name;