imports/imhex
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex.git synced 2026-04-02 13:37:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

sys: Fixed many clang tidy warnings and typos

Browse Source
This commit is contained in:
WerWolv
2022-03-04 20:52:39 +01:00
parent 57c449936f
commit 327e904dbc
64 changed files with 91 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libimhex/include/hex/pattern_language/ast/ast_node_array_variable_decl.hpp
View File

@@ -298,11 +298,11 @@ namespace hex::pl {
}
}
arrayPattern->setEntries(std::move(entries));
if (auto &arrayEntries = arrayPattern->getEntries(); !entries.empty())
arrayPattern->setTypeName(arrayEntries.front()->getTypeName());
arrayPattern->setEntries(std::move(entries));
arrayPattern->setSize(size);
return std::move(arrayPattern);

2
lib/libimhex/include/hex/pattern_language/ast/ast_node_bitfield.hpp
View File

@@ -38,7 +38,7 @@ namespace hex::pl {
std::vector<std::pair<std::string, ASTNode *>> entries;
for (const auto &[name, entry] : this->m_entries)
entries.push_back({ name, entry.get() });
entries.emplace_back(name, entry.get());
if (order == BitfieldOrder::LeftToRight)
std::reverse(entries.begin(), entries.end());

4
lib/libimhex/include/hex/pattern_language/ast/ast_node_control_flow_statement.hpp
View File

@@ -22,10 +22,6 @@ namespace hex::pl {
return std::unique_ptr<ASTNode>(new ASTNodeControlFlowStatement(*this));
}
[[nodiscard]] const std::unique_ptr<ASTNode> &getReturnValue() const {
return this->m_rvalue;
}
[[nodiscard]] std::vector<std::unique_ptr<Pattern>> createPatterns(Evaluator *evaluator) const override {
this->execute(evaluator);

1
lib/libimhex/include/hex/pattern_language/ast/ast_node_union.hpp
View File

@@ -52,7 +52,6 @@ namespace hex::pl {
}
[[nodiscard]] const std::vector<std::shared_ptr<ASTNode>> &getMembers() const { return this->m_members; }
void addMember(std::shared_ptr<ASTNode> &&node) { this->m_members.push_back(std::move(node)); }
private:
std::vector<std::shared_ptr<ASTNode>> m_members;