From 16dc199431858de984fb0ed3b50d60a9a9e511b1 Mon Sep 17 00:00:00 2001 From: WerWolv Date: Sun, 31 Aug 2025 17:31:16 +0200 Subject: [PATCH] fix: Achievement popup setting only being read once at startup --- .../builtin/source/content/views/view_achievements.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/plugins/builtin/source/content/views/view_achievements.cpp b/plugins/builtin/source/content/views/view_achievements.cpp index fc04eedd8..f4a3d6f7b 100644 --- a/plugins/builtin/source/content/views/view_achievements.cpp +++ b/plugins/builtin/source/content/views/view_achievements.cpp @@ -33,14 +33,18 @@ namespace hex::plugin::builtin { } }); + // Load settings { - bool defaultValue = true; #if defined(OS_WEB) - defaultValue = false; + m_showPopup = false; + #else + m_showPopup = true; #endif - m_showPopup = ContentRegistry::Settings::read("hex.builtin.setting.interface", "hex.builtin.setting.interface.achievement_popup", defaultValue); + ContentRegistry::Settings::onChange("hex.builtin.setting.interface", "hex.builtin.setting.interface.achievement_popup", [this](const ContentRegistry::Settings::SettingsValue &value) { + m_showPopup = value.get(true); + }); } }