From 0890043bf444d3f7ceca0cf3d8a0cb13a6873179 Mon Sep 17 00:00:00 2001
From: WerWolv <werwolv98@gmail.com>
Date: Sat, 28 Nov 2020 22:01:50 +0100
Subject: [PATCH] Make Help view no longer appear in View menu

---
 include/views/view.hpp      | 2 ++
 include/views/view_help.hpp | 2 ++
 source/window.cpp           | 6 ++++--
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/views/view.hpp b/include/views/view.hpp
index d41d1446c..21109ead1 100644
--- a/include/views/view.hpp
+++ b/include/views/view.hpp
@@ -52,6 +52,8 @@ namespace hex {
             ImGui::OpenPopup("Error");
         }
 
+        virtual bool hasViewMenuItemEntry() { return true; }
+
         bool& getWindowOpenState() {
             return this->m_windowOpen;
         }
diff --git a/include/views/view_help.hpp b/include/views/view_help.hpp
index b6ce52972..2b14d77ea 100644
--- a/include/views/view_help.hpp
+++ b/include/views/view_help.hpp
@@ -22,6 +22,8 @@ namespace hex {
         void createView() override;
         void createMenu() override;
 
+        bool hasViewMenuItemEntry() override { return false; }
+
     private:
         bool m_aboutWindowOpen = false;
         bool m_patternHelpWindowOpen = false;
diff --git a/source/window.cpp b/source/window.cpp
index 5d05c7211..7ad750109 100644
--- a/source/window.cpp
+++ b/source/window.cpp
@@ -127,8 +127,10 @@ namespace hex {
                     if (ImGui::BeginMenu(menu)) ImGui::EndMenu();
 
                 if (ImGui::BeginMenu("View")) {
-                    for (auto &view : this->m_views)
-                        ImGui::MenuItem((view->getName() + " View").c_str(), "", &view->getWindowOpenState());
+                    for (auto &view : this->m_views) {
+                        if (view->hasViewMenuItemEntry())
+                            ImGui::MenuItem((view->getName() + " View").c_str(), "", &view->getWindowOpenState());
+                    }
                     ImGui::EndMenu();
                 }