From e985cb85d409aa7e54cae8128ac28201e6d1880e Mon Sep 17 00:00:00 2001 From: modmuss50 Date: Wed, 29 Dec 2021 22:02:22 +0000 Subject: [PATCH] Only quote program arguments if they actually contain spaces --- .../net/fabricmc/loom/configuration/ide/RunConfig.java | 7 ++++++- .../net/fabricmc/loom/test/unit/RunConfigUnitTest.groovy | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java b/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java index 3d1b4a08..37069002 100644 --- a/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java +++ b/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java @@ -210,7 +210,12 @@ public class RunConfig { } first = false; - sb.append("\"").append(arg).append("\""); + + if (arg.contains(" ")) { + sb.append("\"").append(arg).append("\""); + } else { + sb.append(arg); + } } return sb.toString(); diff --git a/src/test/groovy/net/fabricmc/loom/test/unit/RunConfigUnitTest.groovy b/src/test/groovy/net/fabricmc/loom/test/unit/RunConfigUnitTest.groovy index 8a804d71..63d00e0c 100644 --- a/src/test/groovy/net/fabricmc/loom/test/unit/RunConfigUnitTest.groovy +++ b/src/test/groovy/net/fabricmc/loom/test/unit/RunConfigUnitTest.groovy @@ -33,6 +33,6 @@ class RunConfigUnitTest extends Specification { def args = RunConfig.joinArguments(["-Dfabric.test=123", "-Dfabric.test=abc 123"]) then: - args == '"-Dfabric.test=123" "-Dfabric.test=abc 123"' + args == '-Dfabric.test=123 "-Dfabric.test=abc 123"' } }