From c62e96b0ae65d13a7434c6202a2f70449dd2cf6b Mon Sep 17 00:00:00 2001 From: Juuz <6596629+Juuxel@users.noreply.github.com> Date: Tue, 13 Jun 2023 13:25:43 +0300 Subject: [PATCH] Fix non-main source set remap configurations publishing by default (#891) Fixes #890. Note that there is *no simple way* to enable publishing for remap configurations created this way anymore as the publishing mode is read during the `createRemapConfigurations` call. This also changes the behaviour of `modClientX` configurations to no longer publish. If that is wanted, I can add a `createRemapConfigurations()` overload with some kind of configurability. --- .../fabricmc/loom/configuration/RemapConfigurations.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/net/fabricmc/loom/configuration/RemapConfigurations.java b/src/main/java/net/fabricmc/loom/configuration/RemapConfigurations.java index 1428c8ee..03349991 100644 --- a/src/main/java/net/fabricmc/loom/configuration/RemapConfigurations.java +++ b/src/main/java/net/fabricmc/loom/configuration/RemapConfigurations.java @@ -183,7 +183,11 @@ public final class RemapConfigurations { configuration.getTargetConfigurationName().convention(targetConfiguration); configuration.getOnCompileClasspath().convention(compileClasspath); configuration.getOnRuntimeClasspath().convention(runtimeClasspath); - configuration.getPublishingMode().convention(publishingMode); + + // Publish only for the main source set. + if (SourceSet.MAIN_SOURCE_SET_NAME.equals(sourceSet.getName())) { + configuration.getPublishingMode().convention(publishingMode); + } }; }