From a45e9f47293d4c33622dcfd022f4276eb0086f0f Mon Sep 17 00:00:00 2001 From: Juuxel <6596629+Juuxel@users.noreply.github.com> Date: Thu, 30 Jul 2020 14:44:03 +0300 Subject: [PATCH] Add warning in RemapJarTask for using mixins in Forge projects --- src/main/java/net/fabricmc/loom/task/RemapJarTask.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/fabricmc/loom/task/RemapJarTask.java b/src/main/java/net/fabricmc/loom/task/RemapJarTask.java index 79e78bcd..5317a9f9 100644 --- a/src/main/java/net/fabricmc/loom/task/RemapJarTask.java +++ b/src/main/java/net/fabricmc/loom/task/RemapJarTask.java @@ -93,7 +93,6 @@ public class RemapJarTask extends Jar { String fromM = "named"; String toM = "official"; // ^ This is passed to SrgRemapJarTask. - // FIXME: The task crashes because it's passed the int -> named mappings instead of full mappings Set classpathFiles = new LinkedHashSet<>( project.getConfigurations().getByName("compileClasspath").getFiles() @@ -107,8 +106,13 @@ public class RemapJarTask extends Jar { remapperBuilder = remapperBuilder.withMappings(TinyRemapperMappingsHelper.create(mappingsProvider.getMappings(), fromM, toM, false)); + // FIXME: The mixin map is named->intermediary, but I think we need named->srg? if (mixinMapFile.exists()) { - remapperBuilder = remapperBuilder.withMappings(TinyUtils.createTinyMappingProvider(mixinMapPath, fromM, toM)); + project.getLogger().error("Mixins in Forge projects are currently not supported."); + + if (false) { + remapperBuilder = remapperBuilder.withMappings(TinyUtils.createTinyMappingProvider(mixinMapPath, fromM, toM)); + } } project.getLogger().lifecycle(":remapping " + input.getFileName());