From a2b541818c5ea76585ed7e15a6878fdf69cbfb1e Mon Sep 17 00:00:00 2001 From: modmuss Date: Fri, 23 Jun 2023 15:29:24 +0100 Subject: [PATCH] Apply AW as a TR AnalyzeVisitor (#892) * Apply AW as a TR AnalyzeVisitor * Update TR --- build.gradle | 2 +- .../AccessWidenerAnalyzeVisitorProvider.java | 62 +++++++++++++++++++ .../loom/configuration/mods/ModProcessor.java | 3 +- 3 files changed, 65 insertions(+), 2 deletions(-) create mode 100644 src/main/java/net/fabricmc/loom/configuration/mods/AccessWidenerAnalyzeVisitorProvider.java diff --git a/build.gradle b/build.gradle index 2e411eeb..ca293ff2 100644 --- a/build.gradle +++ b/build.gradle @@ -85,7 +85,7 @@ dependencies { } // tinyfile management - implementation ('net.fabricmc:tiny-remapper:0.8.5') + implementation ('net.fabricmc:tiny-remapper:0.8.7') implementation 'net.fabricmc:access-widener:2.1.0' implementation 'net.fabricmc:mapping-io:0.2.1' diff --git a/src/main/java/net/fabricmc/loom/configuration/mods/AccessWidenerAnalyzeVisitorProvider.java b/src/main/java/net/fabricmc/loom/configuration/mods/AccessWidenerAnalyzeVisitorProvider.java new file mode 100644 index 00000000..b59373d6 --- /dev/null +++ b/src/main/java/net/fabricmc/loom/configuration/mods/AccessWidenerAnalyzeVisitorProvider.java @@ -0,0 +1,62 @@ +/* + * This file is part of fabric-loom, licensed under the MIT License (MIT). + * + * Copyright (c) 2023 FabricMC + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all + * copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE + * SOFTWARE. + */ + +package net.fabricmc.loom.configuration.mods; + +import java.io.IOException; +import java.util.List; + +import org.objectweb.asm.ClassVisitor; + +import net.fabricmc.accesswidener.AccessWidener; +import net.fabricmc.accesswidener.AccessWidenerClassVisitor; +import net.fabricmc.accesswidener.AccessWidenerReader; +import net.fabricmc.loom.configuration.mods.dependency.ModDependency; +import net.fabricmc.loom.util.Constants; +import net.fabricmc.tinyremapper.TinyRemapper; + +public record AccessWidenerAnalyzeVisitorProvider(AccessWidener accessWidener) implements TinyRemapper.AnalyzeVisitorProvider { + static AccessWidenerAnalyzeVisitorProvider createFromMods(String namespace, List mods) throws IOException { + AccessWidener accessWidener = new AccessWidener(); + accessWidener.visitHeader(namespace); + + for (ModDependency mod : mods) { + final var accessWidenerData = AccessWidenerUtils.readAccessWidenerData(mod.getInputFile()); + + if (accessWidenerData == null) { + continue; + } + + final var reader = new AccessWidenerReader(accessWidener); + reader.read(accessWidenerData.content()); + } + + return new AccessWidenerAnalyzeVisitorProvider(accessWidener); + } + + @Override + public ClassVisitor insertAnalyzeVisitor(int mrjVersion, String className, ClassVisitor next) { + return AccessWidenerClassVisitor.createClassVisitor(Constants.ASM_VERSION, next, accessWidener); + } +} diff --git a/src/main/java/net/fabricmc/loom/configuration/mods/ModProcessor.java b/src/main/java/net/fabricmc/loom/configuration/mods/ModProcessor.java index a1a3d278..f302600a 100644 --- a/src/main/java/net/fabricmc/loom/configuration/mods/ModProcessor.java +++ b/src/main/java/net/fabricmc/loom/configuration/mods/ModProcessor.java @@ -134,7 +134,8 @@ public class ModProcessor { TinyRemapper.Builder builder = TinyRemapper.newRemapper() .withMappings(TinyRemapperHelper.create(mappingConfiguration.getMappingsService(serviceManager).getMappingTree(), fromM, toM, false)) - .renameInvalidLocals(false); + .renameInvalidLocals(false) + .extraAnalyzeVisitor(AccessWidenerAnalyzeVisitorProvider.createFromMods(fromM, remapList)); final KotlinClasspathService kotlinClasspathService = KotlinClasspathService.getOrCreateIfRequired(serviceManager, project); KotlinRemapperClassloader kotlinRemapperClassloader = null;