From 7600472a39b8984cb3de398727b9bb606894015f Mon Sep 17 00:00:00 2001 From: Juuz <6596629+Juuxel@users.noreply.github.com> Date: Thu, 20 Jan 2022 00:06:21 +0200 Subject: [PATCH] Fix unit tests and remove one unnecessary modification to upstream --- .../providers/minecraft/MergedMinecraftProvider.java | 2 +- .../loom/test/unit/IdeaClasspathModificationsTest.groovy | 3 +++ .../layeredmappings/LayeredMappingSpecBuilderTest.groovy | 8 ++++---- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/MergedMinecraftProvider.java b/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/MergedMinecraftProvider.java index 748ce1d7..4d338902 100644 --- a/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/MergedMinecraftProvider.java +++ b/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/MergedMinecraftProvider.java @@ -37,7 +37,7 @@ import net.fabricmc.loom.util.HashedDownloadUtil; import net.fabricmc.stitch.merge.JarMerger; public class MergedMinecraftProvider extends MinecraftProvider { - protected Path minecraftMergedJar; + private Path minecraftMergedJar; public MergedMinecraftProvider(Project project) { super(project); diff --git a/src/test/groovy/net/fabricmc/loom/test/unit/IdeaClasspathModificationsTest.groovy b/src/test/groovy/net/fabricmc/loom/test/unit/IdeaClasspathModificationsTest.groovy index 31677552..e782f42a 100644 --- a/src/test/groovy/net/fabricmc/loom/test/unit/IdeaClasspathModificationsTest.groovy +++ b/src/test/groovy/net/fabricmc/loom/test/unit/IdeaClasspathModificationsTest.groovy @@ -65,6 +65,7 @@ class IdeaClasspathModificationsTest extends Specification { dummyConfig = dummyConfig.replace("%RUN_DIRECTORY%", ".run") dummyConfig = dummyConfig.replace("%PROGRAM_ARGS%", RunConfig.joinArguments([]).replaceAll("\"", """)) dummyConfig = dummyConfig.replace("%VM_ARGS%", RunConfig.joinArguments([]).replaceAll("\"", """)) + dummyConfig = dummyConfig.replace("%ENVS%", "") // Architectury: we have an extra variable that needs to be replaced here return dummyConfig } @@ -73,6 +74,7 @@ class IdeaClasspathModificationsTest extends Specification { private static final String EXPECTED = ''' +