diff --git a/src/main/java/net/fabricmc/loom/api/LoomGradleExtensionAPI.java b/src/main/java/net/fabricmc/loom/api/LoomGradleExtensionAPI.java index ff2d1744..988cbff3 100644 --- a/src/main/java/net/fabricmc/loom/api/LoomGradleExtensionAPI.java +++ b/src/main/java/net/fabricmc/loom/api/LoomGradleExtensionAPI.java @@ -78,6 +78,10 @@ public interface LoomGradleExtensionAPI { Dependency layered(Action action); + /** + * @deprecated Broken due to be evaluated too early. Replaced with "fabric.loom.dontRemap" gradle property. + */ + @Deprecated(forRemoval = true) Property getRemapArchives(); void runs(Action> action); @@ -125,13 +129,9 @@ public interface LoomGradleExtensionAPI { Property getCustomMinecraftManifest(); /** - * If true, Loom will replace the {@code -dev} jars in the {@code *Elements} configurations - * with remapped outgoing variants. - * - *

Will only apply if {@link #getRemapArchives()} is also true. - * - * @return the property controlling the setup of remapped variants + * @deprecated Broken due to be evaluated too early. Replaced with "fabric.loom.disableRemappedVariants" gradle property. */ + @Deprecated(forRemoval = true) Property getSetupRemappedVariants(); /** diff --git a/src/main/java/net/fabricmc/loom/configuration/CompileConfiguration.java b/src/main/java/net/fabricmc/loom/configuration/CompileConfiguration.java index 92f63cc7..a1d8b41a 100644 --- a/src/main/java/net/fabricmc/loom/configuration/CompileConfiguration.java +++ b/src/main/java/net/fabricmc/loom/configuration/CompileConfiguration.java @@ -135,8 +135,6 @@ public final class CompileConfiguration { extension.setDependencyManager(dependencyManager); dependencyManager.handleDependencies(project); - extension.getRemapArchives().finalizeValue(); - MixinExtension mixin = LoomGradleExtension.get(project).getMixin(); if (mixin.getUseLegacyMixinAp().get()) { diff --git a/src/main/java/net/fabricmc/loom/task/RemapTaskConfiguration.java b/src/main/java/net/fabricmc/loom/task/RemapTaskConfiguration.java index 8e2b6522..4af39206 100644 --- a/src/main/java/net/fabricmc/loom/task/RemapTaskConfiguration.java +++ b/src/main/java/net/fabricmc/loom/task/RemapTaskConfiguration.java @@ -48,7 +48,7 @@ public class RemapTaskConfiguration { final TaskContainer tasks = project.getTasks(); final LoomGradleExtension extension = LoomGradleExtension.get(project); - if (!extension.getRemapArchives().get()) { + if (getBooleanProperty(project, "fabric.loom.dontRemap")) { extension.getUnmappedModCollection().from(project.getTasks().getByName(JavaPlugin.JAR_TASK_NAME)); return; } @@ -80,7 +80,7 @@ public class RemapTaskConfiguration { trySetupSourceRemapping(project); - if (!extension.getSetupRemappedVariants().get()) { + if (getBooleanProperty(project, "fabric.loom.disableRemappedVariants")) { return; } @@ -131,7 +131,7 @@ public class RemapTaskConfiguration { tasks.named(BasePlugin.ASSEMBLE_TASK_NAME).configure(task -> task.dependsOn(remapSourcesTask)); - if (!extension.getSetupRemappedVariants().get()) { + if (getBooleanProperty(project, "fabric.loom.disableRemappedVariants")) { return; } @@ -154,4 +154,15 @@ public class RemapTaskConfiguration { } }); } + + private static boolean getBooleanProperty(Project project, String key) { + return project.getProviders().gradleProperty(key).map(string -> { + try { + return Boolean.parseBoolean(string); + } catch (final IllegalArgumentException ex) { + return false; + } + }) + .getOrElse(false); + } } diff --git a/src/main/java/net/fabricmc/loom/util/Constants.java b/src/main/java/net/fabricmc/loom/util/Constants.java index f5b6a8b0..d51cf66b 100644 --- a/src/main/java/net/fabricmc/loom/util/Constants.java +++ b/src/main/java/net/fabricmc/loom/util/Constants.java @@ -30,7 +30,7 @@ import org.objectweb.asm.Opcodes; public class Constants { public static final String LIBRARIES_BASE = "https://libraries.minecraft.net/"; public static final String RESOURCES_BASE = "https://resources.download.minecraft.net/"; - public static final String VERSION_MANIFESTS = "https://launchermeta.mojang.com/mc/game/version_manifest_v2.json"; + public static final String VERSION_MANIFESTS = "https://piston-meta.mojang.com/mc/game/version_manifest_v2.json"; public static final String EXPERIMENTAL_VERSIONS = "https://maven.fabricmc.net/net/minecraft/experimental_versions.json"; public static final String FABRIC_REPOSITORY = "https://maven.fabricmc.net/";