imports/architectury-loom
1
0
Fork 0
mirror of https://github.com/architectury/architectury-loom.git synced 2026-04-02 05:27:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

Handle fabric.mod.json file being empty (#1280)

Browse Source 
* Throw a nicer error when the fabric.mod.json file is empty

* Don't fail just log.
This commit is contained in:
modmuss
2025-04-07 11:54:08 +01:00
committed by GitHub
parent 186b774a2e
commit 2af4b7e591
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/net/fabricmc/loom/util/fmj/FabricModJsonFactory.java
View File

@@ -116,7 +116,15 @@ public final class FabricModJsonFactory {
}
try (Reader reader = Files.newBufferedReader(file.toPath(), StandardCharsets.UTF_8)) {
return create(LoomGradlePlugin.GSON.fromJson(reader, JsonObject.class), new FabricModJsonSource.SourceSetSource(project, sourceSets));
final JsonObject modJson = LoomGradlePlugin.GSON.fromJson(reader, JsonObject.class);
if (modJson == null) {
// fromJson returns null if the file is empty
LOGGER.warn("Failed to parse empty fabric.mod.json: {}", file.getAbsolutePath());
return null;
}
return create(modJson, new FabricModJsonSource.SourceSetSource(project, sourceSets));
} catch (JsonSyntaxException e) {
LOGGER.warn("Failed to parse fabric.mod.json: {}", file.getAbsolutePath());
return null;