From 7c179b3b4118ad918a2f9f8d76b1a2b6470216fb Mon Sep 17 00:00:00 2001 From: Nik Date: Sun, 8 Jan 2023 16:19:38 +0100 Subject: [PATCH] git: Added note for `application/octet-stream` MIME type to PR template --- .github/PULL_REQUEST_TEMPLATE/pattern_template.md | 1 + patterns/dmg.hexpat | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pattern_template.md b/.github/PULL_REQUEST_TEMPLATE/pattern_template.md index eb9b64c..b0b4955 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pattern_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pattern_template.md @@ -6,5 +6,6 @@ - [ ] A pattern for this format doesn't exist yet (or this PR improves the existing one) - [ ] The new pattern has been added to the relevant table in the Readme - [ ] The pattern was associated with all relevant MIME types (using `#pragma MIME mime-type` in the source code) + - Make sure to never use `application/octet-stream` here as that means "Unidentifiable binary data" - [ ] A test file for this pattern has been added to [/tests/patterns/test_data](/tests/patterns/test_data) - Try to keep this file below ~ 1 MB diff --git a/patterns/dmg.hexpat b/patterns/dmg.hexpat index a1f4dff..bd536d4 100644 --- a/patterns/dmg.hexpat +++ b/patterns/dmg.hexpat @@ -1,4 +1,3 @@ -#pragma MIME application/octet-stream #pragma endian big #include