imports/ImHex-Patterns
1
0
Fork 0
mirror of https://github.com/WerWolv/ImHex-Patterns.git synced 2026-03-28 07:47:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

themes: Updated the custom themes to the new text editor color palettes (#255)

Browse Source 
* Updated the custom themes to the new text editor color palettes designed for full syntax highlighting, but the existing themes should look just like they did before.

* impr: renamed pattern-placed-variable to calculated-pointer and added view
fix: pe pattern could read past the end of file if symbol search option was turned on and input file had no symbols. In that case a StringTable array that has 1 element would be created and place at offset 0 where the size variable was set to a large number creating the error. The fix is to set the size of the array using numberOfSymbols>0

* Fix: that was a bad choice for the size of the stringTable array because  even if findSymbols is not on the file can contain symbols. This was causing the pe unit test to fail. To get the right array size use sizeof(symbolTable)>0 which will be 1 only if findSymbols is true and the file actually contains symbols
This commit is contained in:
paxcut
2024-11-17 05:52:30 -07:00
committed by GitHub
parent 8a6bb6612b
commit 6697fc23a4
7 changed files with 175 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
patterns/pe.hexpat
View File

@@ -1209,7 +1209,7 @@ struct StringTable {
SymbolString strings[while($ < addressof(this) + size)];
} [[inline]];
StringTable stringTable[checkForSymbols] @ addressof(symbolTable) + sizeof(symbolTable);
StringTable stringTable[sizeof(symbolTable)>0] @ addressof(symbolTable) + sizeof(symbolTable);
// Rich Header
bool checkForRichHeader in;