added Error Prone (https://errorprone.info/) and fixed reported errors and warnings

- CI runs Error Prone with Java 11
- use Gradle task `errorprone` to run it on development machine
- fixes are mostly cosmetic except:
  - use Locale.ENGLISH for String.toLowerCase()
  - use explicit character encoding when reading/writing files
  - TabbedPane: wrong logic in mouse-wheel scrolling
  - SplitPane: simplified property change listener (fixes hiding field `propertyChangeListener` of superclass)
This commit is contained in:
Karl Tauber
2023-05-19 22:58:12 +02:00
parent 9d84501bc8
commit 97018df2f9
46 changed files with 167 additions and 86 deletions

View File

@@ -46,6 +46,6 @@ public class FlatLafThemeEditor
System.setProperty( "apple.awt.application.appearance", "system" );
}
FlatThemeFileEditor.main( args );
FlatThemeFileEditor.launch( args );
}
}

View File

@@ -52,6 +52,7 @@ class FlatThemeEditorOverlay
private Font font;
private Font baseFont;
@SuppressWarnings( "FormatString" ) // Error Prone
@Override
public void paint( Graphics g, JComponent c ) {
// paint the syntax text area

View File

@@ -102,7 +102,7 @@ class FlatThemeFileEditor
private final FlatThemePropertiesBaseManager propertiesBaseManager = new FlatThemePropertiesBaseManager();
private final JButton newButton;
static void main( String[] args ) {
static void launch( String[] args ) {
File dir = (args.length > 0)
? new File( args[0] )
: null;
@@ -1306,7 +1306,7 @@ class FlatThemeFileEditor
super.addElement( obj );
} else {
int index = binarySearch( this, obj, comparator );
insertElementAt( obj, (index < 0) ? ((-index)-1) : index );
insertElementAt( obj, (index < 0) ? (-index - 1) : index );
}
}