From 68a7a60ff21b2f9e0c9b571a53980d166739126a Mon Sep 17 00:00:00 2001 From: Karl Tauber Date: Tue, 12 Apr 2022 13:28:39 +0200 Subject: [PATCH] FileChooser: enabled full row selection for details view to fix alternate row coloring (issue #512) --- CHANGELOG.md | 2 ++ .../src/main/resources/com/formdev/flatlaf/FlatLaf.properties | 1 + flatlaf-testing/dumps/uidefaults/FlatDarkLaf_1.8.0.txt | 1 + flatlaf-testing/dumps/uidefaults/FlatLightLaf_1.8.0.txt | 1 + flatlaf-testing/dumps/uidefaults/FlatTestLaf_1.8.0.txt | 1 + .../resources/com/formdev/flatlaf/themeeditor/FlatLafUIKeys.txt | 2 ++ 6 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c3f968b..b3248d74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ FlatLaf Change Log character encoding used in Windows taskbar. (issue #502) - Button: Fixed icon layout and preferred width of default buttons that use bold font. (issue #506) +- FileChooser: Enabled full row selection for details view to fix alternate row + coloring. (issue #512) - ToolBar: Fixed endless loop in focus navigation that may occur under special circumstances. (issue #505) - IntelliJ Themes: `Component.accentColor` UI property now has useful theme diff --git a/flatlaf-core/src/main/resources/com/formdev/flatlaf/FlatLaf.properties b/flatlaf-core/src/main/resources/com/formdev/flatlaf/FlatLaf.properties index daaa2e76..eaf3b1d9 100644 --- a/flatlaf-core/src/main/resources/com/formdev/flatlaf/FlatLaf.properties +++ b/flatlaf-core/src/main/resources/com/formdev/flatlaf/FlatLaf.properties @@ -332,6 +332,7 @@ FileView.fileIcon = com.formdev.flatlaf.icons.FlatFileViewFileIcon FileView.computerIcon = com.formdev.flatlaf.icons.FlatFileViewComputerIcon FileView.hardDriveIcon = com.formdev.flatlaf.icons.FlatFileViewHardDriveIcon FileView.floppyDriveIcon = com.formdev.flatlaf.icons.FlatFileViewFloppyDriveIcon +FileView.fullRowSelection = true #---- FormattedTextField ---- diff --git a/flatlaf-testing/dumps/uidefaults/FlatDarkLaf_1.8.0.txt b/flatlaf-testing/dumps/uidefaults/FlatDarkLaf_1.8.0.txt index 1a170334..557dc459 100644 --- a/flatlaf-testing/dumps/uidefaults/FlatDarkLaf_1.8.0.txt +++ b/flatlaf-testing/dumps/uidefaults/FlatDarkLaf_1.8.0.txt @@ -313,6 +313,7 @@ FileView.computerIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFil FileView.directoryIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewDirectoryIcon [UI] FileView.fileIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewFileIcon [UI] FileView.floppyDriveIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewFloppyDriveIcon [UI] +FileView.fullRowSelection true FileView.hardDriveIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewHardDriveIcon [UI] diff --git a/flatlaf-testing/dumps/uidefaults/FlatLightLaf_1.8.0.txt b/flatlaf-testing/dumps/uidefaults/FlatLightLaf_1.8.0.txt index 31cece69..7992ca66 100644 --- a/flatlaf-testing/dumps/uidefaults/FlatLightLaf_1.8.0.txt +++ b/flatlaf-testing/dumps/uidefaults/FlatLightLaf_1.8.0.txt @@ -317,6 +317,7 @@ FileView.computerIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFil FileView.directoryIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewDirectoryIcon [UI] FileView.fileIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewFileIcon [UI] FileView.floppyDriveIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewFloppyDriveIcon [UI] +FileView.fullRowSelection true FileView.hardDriveIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewHardDriveIcon [UI] diff --git a/flatlaf-testing/dumps/uidefaults/FlatTestLaf_1.8.0.txt b/flatlaf-testing/dumps/uidefaults/FlatTestLaf_1.8.0.txt index 4e3aa1ed..25dd0eb2 100644 --- a/flatlaf-testing/dumps/uidefaults/FlatTestLaf_1.8.0.txt +++ b/flatlaf-testing/dumps/uidefaults/FlatTestLaf_1.8.0.txt @@ -318,6 +318,7 @@ FileView.computerIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFil FileView.directoryIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewDirectoryIcon [UI] FileView.fileIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewFileIcon [UI] FileView.floppyDriveIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewFloppyDriveIcon [UI] +FileView.fullRowSelection true FileView.hardDriveIcon [lazy] 16,16 com.formdev.flatlaf.icons.FlatFileViewHardDriveIcon [UI] diff --git a/flatlaf-theme-editor/src/main/resources/com/formdev/flatlaf/themeeditor/FlatLafUIKeys.txt b/flatlaf-theme-editor/src/main/resources/com/formdev/flatlaf/themeeditor/FlatLafUIKeys.txt index 2cc6eacc..7c69d876 100644 --- a/flatlaf-theme-editor/src/main/resources/com/formdev/flatlaf/themeeditor/FlatLafUIKeys.txt +++ b/flatlaf-theme-editor/src/main/resources/com/formdev/flatlaf/themeeditor/FlatLafUIKeys.txt @@ -260,6 +260,7 @@ FileView.computerIcon FileView.directoryIcon FileView.fileIcon FileView.floppyDriveIcon +FileView.fullRowSelection FileView.hardDriveIcon FormattedTextField.background FormattedTextField.border @@ -848,6 +849,7 @@ TabbedPane.tabsPopupPolicy TabbedPane.textIconGap TabbedPane.underlineColor TabbedPaneUI +Table.alternateRowColor Table.ancestorInputMap Table.ancestorInputMap.RightToLeft Table.ascendingSortIcon